test: cover validated redirect guard#248
Closed
dangelo352 wants to merge 1 commit into
Closed
Conversation
Contributor
|
thanks for the work here — but our flow is that you need to be assigned to the issue before opening a PR for it. #227 isn't assigned to you, so i'm closing this as invalid for now. please claim #227 first (comment on the issue or grab it on the GrantFox board), then re-raise and we'll review right away. https://discord.gg/xvNAvMJf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #227
Summary
redirect_fundsreturnsError::NotAuthorizedfor a validated vault after the deadlinefailure_destinationremains unchanged andrelease_fundsstill payssuccess_destinationTESTING_GUIDE.mdtests/proptest_timestamps.rsthat CI expectsValidation
CARGO_TARGET_DIR=/tmp/disciplr-redirect-target cargo test test_validated_vault_cannot_redirect_after_deadline_and_can_releaseCARGO_TARGET_DIR=/tmp/disciplr-redirect-target cargo test— all tests passedgit diff --check